Re: timed PgConnection::Connect

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Denis A Ustimenko <denis(at)oldham(dot)ru>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: timed PgConnection::Connect
Date: 2002-08-07 13:52:05
Message-ID: 15216.1028728325@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Denis A Ustimenko <denis(at)oldham(dot)ru> writes:
> I write this to put timeout parameter in PgConnection::Connect.

This patch seems really messy. In the first place, the timeout isn't on
total connection delay, but on individual waits of which there will be
several. I'd think that's not really what you want. In the second
place, I'd expect a timeout to be specified as a new optional parameter
in connection strings, not as an ad-hoc additional parameter in the API.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-08-07 13:59:33 Re: current_database()
Previous Message Rod Taylor 2002-08-07 13:15:41 Re: current_database()