Re: IndexJoin memory problem using spgist and boxes

From: Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Anton Dignös <anton(dot)dignoes(at)gmail(dot)com>
Subject: Re: IndexJoin memory problem using spgist and boxes
Date: 2018-03-19 18:43:59
Message-ID: 152148503949.12147.12490438864366522239.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

The updated version looks good to me. make installcheck under valgrind finds no errors. I also tried the T1 and T5 datasets, here are the timings and memory usage:
T1 T5
Vanilla 2G/24.2 s over 7G/didn't wait
Patch v2 144M/23.0 s 148M/108 s

The new status of this patch is: Ready for Committer

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Terry Phelps 2018-03-19 19:10:35 Compile error while building postgresql 10.3
Previous Message Tomas Vondra 2018-03-19 18:40:54 Re: [PROPOSAL] Shared Ispell dictionaries