|From:||Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>|
|Cc:||Andrey Borodin <x4mmm(at)yandex-team(dot)ru>|
|Subject:||Re: New gist vacuum.|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
I have added small change to patch to allow it be compiled using msvc (uint64_t -> uint64).
Everything seems to work, check-world is passing.
Actually patch fixes two issues:
1) Partial GIST indexes now have corrent tuples count estimation.
2) Now subsequent calls to VACUUM on GIST index (like "VACCUM table_name") do not change tuples count to estimated number of tuples in table (which is changed even without any updates in table due current implementation).
I think it is fine to commit.
Patch is also availble on github:
I'll attach patch file next message.
The new status of this patch is: Ready for Committer
|Next Message||Michail Nikolaev||2018-02-25 13:54:18||Re: New gist vacuum.|
|Previous Message||Craig Ringer||2018-02-25 12:27:59||Re: handling of heap rewrites in logical decoding|