Re: New gist vacuum.

From: Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Subject: Re: New gist vacuum.
Date: 2018-02-25 13:49:02
Message-ID: 151956654251.6915.675951950408204404.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested

Hello.

I have added small change to patch to allow it be compiled using msvc (uint64_t -> uint64).
Everything seems to work, check-world is passing.

Actually patch fixes two issues:
1) Partial GIST indexes now have corrent tuples count estimation.
2) Now subsequent calls to VACUUM on GIST index (like "VACCUM table_name") do not change tuples count to estimated number of tuples in table (which is changed even without any updates in table due current implementation).

I think it is fine to commit.

Patch is also availble on github:
https://github.com/michail-nikolaev/postgres/commit/ff5171b586e4eb60ea5d15a18055d8ea4e44d244?ts=4

I'll attach patch file next message.

The new status of this patch is: Ready for Committer

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michail Nikolaev 2018-02-25 13:54:18 Re: New gist vacuum.
Previous Message Craig Ringer 2018-02-25 12:27:59 Re: handling of heap rewrites in logical decoding