| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql: Add role's membership options to the \du+ command |
| Date: | 2023-04-04 16:13:10 |
| Message-ID: | 1518709.1680624790@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> I've marked this Ready for Committer.
Hmm ... not sure I like the proposed output. The 'a', 'i', 's'
annotations are short but they don't have much else to recommend them.
On the other hand, there's nearby precedent for single-letter
abbreviations in ACL displays. Nobody particularly likes those,
though. Also, if we're modeling this on ACLs then the display
could be further shortened to "(ais)" or the like.
Also, the patch is ignoring i18n issues. I suppose if we stick with
said single-letter abbreviations we'd not translate them, but the
construction "rolename from rolename" ought to be translatable IMO.
Perhaps it'd be enough to allow replacement of "from", but I wonder
if the phrase order would need to be different in some languages?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2023-04-04 16:38:04 | Re: psql: Add role's membership options to the \du+ command |
| Previous Message | Robert Haas | 2023-04-04 16:09:58 | Re: running logical replication as the subscription owner |