From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Cc: | Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru> |
Subject: | Re: new function for tsquery creartion |
Date: | 2018-01-15 13:00:55 |
Message-ID: | 151602125554.25640.2584561162347369841.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Here are a few minor issues:
```
+/*
+ * Checks if 'str' starts with a 'prefix'
+ */
+static bool
+has_prefix(char * str, char * prefix)
+{
+ if (strlen(prefix) > strlen(str))
+ {
+ return false;
+ }
+ return strstr(str, prefix) == str;
+}
```
strlen() check is redundant.
```
+ case OP_AROUND:
+ snprintf(in->cur, 256, " AROUND(%d) %s", distance, nrm.buf);
+ break;
```
Instead of the constant 256 it's better to use sizeof().
Apart from these issues this patch looks not bad.
The new status of this patch is: Ready for Committer
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-01-15 13:36:04 | Re: WIP: a way forward on bootstrap data |
Previous Message | Joe Wildish | 2018-01-15 12:50:52 | Re: Implementing SQL ASSERTION |