Fuzzy thinking in is_publishable_class

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Fuzzy thinking in is_publishable_class
Date: 2019-05-07 19:25:11
Message-ID: 15150.1557257111@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

is_publishable_class has a test "relid >= FirstNormalObjectId",
which I think we should drop, for two reasons:

1. It makes the comment claiming that this function tests the same
things as check_publication_add_relation a lie.

2. The comment about it claims that the purpose is to reject
information_schema relations, but if that's so, it's ineffective.
We consider it supported to drop and recreate information_schema,
and have indeed recommended doing so for some minor-version
upgrades. After that, the information_schema relations would no
longer have OIDs recognizable to this test.

So what is the motivation for this test? If there's an important
reason for it, we need to find a less fragile way to express it.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-05-07 19:29:52 Re: PG12, PGXS and linking pgfeutils
Previous Message Thomas Munro 2019-05-07 18:56:09 Re: We're leaking predicate locks in HEAD