Re: 7.4.1 release status - Turkish Locale

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ntufar(at)pisem(dot)net
Cc: pgsql-hackers(at)postgresql(dot)org, devrim(at)tdmsoft(dot)com
Subject: Re: 7.4.1 release status - Turkish Locale
Date: 2004-02-01 08:17:26
Message-ID: 15123.1075623446@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Nicolai Tufar" <ntufar(at)pisem(dot)net> writes:
>> A possible compromise is to apply ASCII downcasing (same as in
>> keywords.c) for 7-bit-ASCII characters, and apply tolower() only
>> for character codes above 127. In other words

> If we go this way why not make a special case only and only for 'I'
> Character and not all 7-bit ASCII:

It seems to me that that's too narrow a definition of the problem.
I think we should state our goal as "we don't want bizarre locale
definitions to interfere with downcasing of the basic ASCII letters".
If we put in a special case for 'I' we will fix the known problem
with Turkish, but what other strange locales might be out there?
And if we don't trust tolower() for 'I', why should we trust it
for 'A'-'Z'?

What it comes down to is that by training and experience, I always
expect that any bug might be just one example of a whole class of bugs.
You have to look for the related cases that might happen in future,
not only fix the case that's under your nose.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicolai Tufar 2004-02-01 09:50:01 Re: 7.4.1 release status - Turkish Locale
Previous Message Nicolai Tufar 2004-02-01 07:56:29 Re: 7.4.1 release status - Turkish Locale