Re: patch: psql - enforce constant width of last column

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: psql - enforce constant width of last column
Date: 2019-11-04 20:55:46
Message-ID: 15052.1572900946@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> st 18. 9. 2019 v 12:52 odesílatel Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com> napsal:
>> does this patch have any value for psql without pspg?

> The benefit of this patch is just for pspg users today.

TBH, I think we should just reject this patch. It makes psql's
table-printing behavior even more complicated than it was before.
And I don't see how pspg gets any benefit --- you'll still have
to deal with the old code, for an indefinite time into the future.

Moreover, *other* programs that pay close attention to the output
format will be forced to deal with the possibility that this flag
has been turned on, which typically they wouldn't even have a way
to find out. So I think you're basically trying to export your
problems onto everyone else.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-11-04 20:58:51 Re: Collation versioning
Previous Message Andres Freund 2019-11-04 20:41:16 Re: Missed check for too-many-children in bgworker spawning