Another usability issue with our TAP tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Another usability issue with our TAP tests
Date: 2018-07-16 17:13:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Since "make check-world" is rather chatty, if you get a failure while
running it under high parallelism, the location of the failure has often
scrolled off the terminal window by the time all the other subjobs exit.
This is not a huge problem for tests using our traditional infrastructure,
because you can just run "git status" to look for regression.diffs files.
But a TAP test failure leaves nothing behind that git will consider
unusual. I've repeatedly had to run check-world with no parallelism
(wasting many minutes) in order to locate which test actually failed.

I'm not sure about a good way to improve this. One idea that comes
to mind is to tweak the "make check" rules so that the tmp_check
subdirectories are automatically deleted on successful completion,
but not on failure, and then remove tmp_check from the .gitignore lists.
But the trouble with that is sometimes you want to look at the test logs
afterwards, even when make thought the test succeeded.


regards, tom lane


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-07-16 17:21:17 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Robert Haas 2018-07-16 16:15:46 Re: [HACKERS] logical decoding of two-phase transactions