Re: Minor improvements to test log navigability

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor improvements to test log navigability
Date: 2022-05-17 03:40:52
Message-ID: 1501597.1652758852@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> ... Admittedly that is nothing compared to the huge amount of extra log
> spam caused by regression.diffs filling up with these:

Yeah, that's really the main problem.

> I wonder if there would be a good way to filter those "never managed
> to connect" cases out... Exit code 2 (EXIT_BADCONN) is not the
> answer, because you get that also for servers that go away due to a
> crash where you do want to be able to see the diff, for information
> about where it crashed.

Maybe pg_regress could check that postmaster.pid is still there
before launching each new test script? (Obviously this all applies
only to "make check" not "make installcheck".)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-05-17 03:56:28 Re: Skipping schema changes in publication
Previous Message Thomas Munro 2022-05-17 03:31:24 Re: Backends stunk in wait event IPC/MessageQueueInternal