Re: pg_plan_advice

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> .... Or maybe the recent
> "timedout" errors in the buildfarm are a sign that 1000s isn't long
> enough for this more-intensive run:

> https://buildfarm.postgresql.org/cgi-bin/show_failures.pl?max_days=3&stage=timedout&filter=Submit

I think those are all mostly-unrelated. icarus has never yet been
stable enough to complete a BF run, and morepork and schnauzer's
wait_timeout parameters were set to 7200 (2 hours) which the test run
had organically grown to exceed. Maybe test_plan_advice helped push
them over the edge, but they were going to need a larger setting
sometime soon anyway. (And I see Mikael's fixed that.)

> If so, that would be sad. On my local machine, which is a ~3 yo
> MacBook, running just the "regress" test suite takes ~11.1 s, and
> running just the "test_plan_advice" suite takes ~12s, so I admit that
> I'm slightly confused about why this is having such a big impact for
> you and Tom.

Please note that I was citing the runtime of a much slower machine
(longfin is a 2018 mac mini). But in any case, what I was griping
about was the additional cost added to a buildfarm run; I don't see
that test_plan_advice is a lot slower than the main regression tests.
It's just that those are already a significant investment, and we
just iterated them another time.

regards, tom lane