| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Improve errors when setting incorrect bounds for SSL protocols |
| Date: | 2020-04-29 11:57:49 |
| Message-ID: | 14BFD060-8C9D-43B4-897D-D5D9AA6FC92B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Working in the TLS corners of the backend, I found while re-reviewing and
re-testing for the release that this patch actually was a small, but vital,
brick shy of a load. The error handling is always invoked due to a set of
missing braces. Going into the check will cause the context to be freed and
be_tls_open_server error out. The tests added narrowly escapes it by not
setting the max version in the final test, but I'm not sure it's worth changing
that now as not setting a value is an interesting testcase too. Sorry for
missing that at the time of reviewing.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| minmaxproto_guc.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-04-29 12:27:22 | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Previous Message | tushar | 2020-04-29 11:46:40 | Re: [Proposal] Global temporary tables |