replication_slot_catalog_xmin not explicitly initialized when creating procArray

From: "Wong, Yi Wen" <yiwong(at)amazon(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: replication_slot_catalog_xmin not explicitly initialized when creating procArray
Date: 2017-07-07 17:19:41
Message-ID: 1499447984689.7466@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

replication_slot_catalog_xmin is not explictly initialized to InvalidTransactionId.

Normally, there isn't an issue with this because a freshly mmap'd memory is zeroed, and the value of InvalidTransactionId is 0.

If the memory was not 0 for whatever reason, VACUUM would not behave as expected.

See attached patch.

Thanks,

Yi Wen

Attachment Content-Type Size
init_catalog_xmin.patch application/octet-stream 594 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-07-07 18:19:44 Re: [WIP] Zipfian distribution in pgbench
Previous Message David Fetter 2017-07-07 17:18:33 Re: SCRAM auth and Pgpool-II