From: | Sergey Koposov <skoposov(at)cmu(dot)edu> |
---|---|
To: | "pg(at)bowt(dot)ie" <pg(at)bowt(dot)ie> |
Cc: | "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: BUG #14722: Segfault in tuplesort_heap_siftup, 32 bit overflow |
Date: | 2017-06-29 17:50:36 |
Message-ID: | 1498758636.21587.82.camel@cmu.edu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Thu, 2017-06-29 at 10:00 -0700, Peter Geoghegan wrote:
> On Thu, Jun 29, 2017 at 9:16 AM, <skoposov(at)cmu(dot)edu> wrote:
> > From a quick look of the code it looks to me that the reason for the bug is
> > the 32 bit int overflow in the j=2*i+1 calculation inside the
> > tuplesort_heap_siftup leading to negative values of j.
>
> It seems likely that the explanation is as simple as that. This
> happens during run generation with replacement selection. All versions
> are affected, but version 9.6+ is dramatically less likely to be
> affected, because replacement selection was all but killed in Postgres
> 9.6.
>
> This is an oversight in commit 263865a. The fix is to use a variable
> that won't overflow in tuplesort_heap_siftup() -- this is probably a
> one-liner, because when the variable overflows today, the correct
> behavior would be for control to break out of the loop that declares
> the overflowing variable "j", and, I don't see any similar problem in
> other heap maintenance routines. It's a very isolated problem.
>
> I could write a patch.
For the time being I've just changed the type of i,j from int to long
(or int64) and I am running the index creation now. I let you submit a
patch -- thanks in advance.
I also noticed that the availMem variable was negative in the printout
of the TupleSortState.
availMem =-6442450776,
I don't know whether that's an issue on its own or was caused by the
(i,j) overflow. (availMem seems to be int64 variable though).
Sergey
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2017-06-29 18:10:13 | Re: BUG #14722: Segfault in tuplesort_heap_siftup, 32 bit overflow |
Previous Message | Peter Geoghegan | 2017-06-29 17:00:41 | Re: BUG #14722: Segfault in tuplesort_heap_siftup, 32 bit overflow |