| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: COPY WITH CSV FORCE QUOTE * -- REVIEW |
| Date: | 2009-07-24 23:31:13 |
| Message-ID: | 14965.1248478273@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I have reviewed this and made a small tweak in the docco. I'm just about
> ready to commit this, but I'm still slightly worried that passing NULL
> to denote all columns in this piece of grammar:
> | FORCE QUOTE '*'
> {
> $$ = makeDefElem("force_quote", NULL);
> }
> might be less than robust - it just feels slightly hacky, so I'd
> appreciate others' thoughts.
I agree, that's ugly. Why don't you use an A_Star node?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-24 23:39:11 | Re: Non-blocking communication between a frontend and a backend (pqcomm) |
| Previous Message | Andrew Dunstan | 2009-07-24 23:25:51 | Re: COPY WITH CSV FORCE QUOTE * -- REVIEW |