Skip site navigation (1) Skip section navigation (2)

Re: transformExpr() refactor

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: transformExpr() refactor
Date: 2005-01-18 05:54:31
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> Why I think the patch is a good idea: 900 line functions are almost
> universally bad (in fact, I'd be tempted to remove the "almost").

[ shrug... ] 900 line functions that consist of absolutely independent
case arms are not any harder to read than the alternative.  I won't
stand in the way of you doing this, but I think you could find more
profitable uses for your time.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Tom LaneDate: 2005-01-18 06:02:15
Subject: Re: WIP: pl/pgsql cleanup
Previous:From: Neil ConwayDate: 2005-01-18 05:43:40
Subject: Re: rtree: improve performance, tuple killing

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group