Re: transformExpr() refactor

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: transformExpr() refactor
Date: 2005-01-18 05:54:31
Message-ID: 14937.1106027671@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> Why I think the patch is a good idea: 900 line functions are almost
> universally bad (in fact, I'd be tempted to remove the "almost").

[ shrug... ] 900 line functions that consist of absolutely independent
case arms are not any harder to read than the alternative. I won't
stand in the way of you doing this, but I think you could find more
profitable uses for your time.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-01-18 06:02:15 Re: WIP: pl/pgsql cleanup
Previous Message Neil Conway 2005-01-18 05:43:40 Re: rtree: improve performance, tuple killing