| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Jesse Zhang <sbjesse(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-01-22 23:14:03 |
| Message-ID: | 1492903.1674429243@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jelte Fennema <postgres(at)jeltef(dot)nl> writes:
> Maybe I'm not understanding your issue correctly, but for such
> a case you could push two commits at the same time.
I don't know that much about git commit hooks, but do they really
only check the final state of a series of commits?
In any case, I'm still down on the idea of checking this in a
commit hook because of the complexity and lack of transparency
of such a check. If you think your commit is correctly indented,
but the hook (running on somebody else's machine) disagrees,
how are you going to debug that? I don't want to get into such
a situation, especially since Murphy's law guarantees that it
would mainly bite people under time pressure, like when pushing
a security fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-01-22 23:21:21 | Re: pg_stats and range statistics |
| Previous Message | Joel Jacobson | 2023-01-22 22:48:37 | Re: [PATCH] Use 128-bit math to accelerate numeric division, when 8 < divisor digits <= 16 |