Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: schefner20(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster
Date: 2026-11-16 21:51:58
Message-ID: 148733.1794865918@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I also feel like it's counterintuitive that pg_upgrade --check can
> destroy data, regardless of anything else. One could certainly fail to
> read the documentation and fail to realize that risk.

Perhaps it'd be reasonable for --check mode to not risk a
start_postmaster() action, but just bail out if it sees a
postmaster.pid file. However, that doesn't do diddly-squat
for what I consider the real hazard here: the described
environment breaks our safeguards against starting two postmasters
in the same data directory. That WILL eat your data someday,
and there's nothing we can do to prevent it.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message David Rowley 2026-11-16 22:34:21 Re: PG 18 JIT regression: int4range hash breaks multi-key GROUP BY
Previous Message Robert Haas 2026-11-16 21:36:55 Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster