Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I also feel like it's counterintuitive that pg_upgrade --check can
> destroy data, regardless of anything else. One could certainly fail to
> read the documentation and fail to realize that risk.
Perhaps it'd be reasonable for --check mode to not risk a
start_postmaster() action, but just bail out if it sees a
postmaster.pid file. However, that doesn't do diddly-squat
for what I consider the real hazard here: the described
environment breaks our safeguards against starting two postmasters
in the same data directory. That WILL eat your data someday,
and there's nothing we can do to prevent it.
regards, tom lane