Re: pg_regress breaks on msys

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress breaks on msys
Date: 2006-07-19 18:34:39
Message-ID: 14789.1153334079@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> Hmm, that suggests that our code works *only* if there's white space in
>> all the paths !? Seems unlikely that this description is fully correct,
>> or we'd have had problems before.

> It is saying _all_ these have to be true, and we already quote
> executables, and the string, so we always have more than two quotes:

Well, the description is about as clear as mud, because it's not saying
which two quote characters it's talking about. I read it as talking
about the two quote characters around any one word/pathname. If you
think it's talking about the two quote characters we put around the
whole command (the SYSTEMQUOTE dodge), then we're certainly going to
fail the "no special characters" test, because all these commands use
I/O redirection symbols.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-07-19 18:39:42 Re: pg_regress breaks on msys
Previous Message Tom Lane 2006-07-19 18:29:23 Re: plPHP and plRuby

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2006-07-19 18:39:42 Re: pg_regress breaks on msys
Previous Message Bruce Momjian 2006-07-19 18:24:29 Re: pg_regress breaks on msys