Re: [GENERAL] pg_upgrade from 9.5 to 9.6 fails with "invalid argument"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Thomas Kellerer <spam_eater(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [GENERAL] pg_upgrade from 9.5 to 9.6 fails with "invalid argument"
Date: 2016-09-29 22:08:53
Message-ID: 14719.1475186933@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> I wouldn't even put a lot of faith in the errno being meaningful,
>> considering that it does close() calls before capturing the errno.

> So we do close() in a bunch of places while closing shop, which calls
> _close() on Windows; this function sets errno.

But only on failure, no? The close()s usually shouldn't fail, and
therefore shouldn't change errno, it's just that you can't trust that
100%.

I think likely what's happening is that we're seeing a leftover value from
some previous syscall that set GetLastError's result (and, presumably,
wasn't fatal so far as pg_upgrade was concerned).

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Colin Morelli 2016-09-29 23:03:19 Filtering by UUID
Previous Message Tom Lane 2016-09-29 21:51:53 Re: [HACKERS] pg_upgrade from 9.5 to 9.6 fails with "invalid argument"

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-09-30 00:07:42 Re: Hash Indexes
Previous Message Tom Lane 2016-09-29 21:53:22 Re: pg_basebackup, pg_receivexlog and data durability (was: silent data loss with ext4 / all current versions)