Re: Why does pg_bsd_indent need to be installed?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why does pg_bsd_indent need to be installed?
Date: 2023-05-25 13:09:45
Message-ID: 1470081.1685020185@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Why does pgindent require that pg_bsd_indent be installed in the path?
> Couldn't pgindent call the pg_bsd_indent built inside the tree? That
> would make the whole process much smoother.

Well, the current expectation is that you run it in a distclean'd
tree, in which case it won't be there. VPATH builds would have
a problem finding it as well.

I'm not sure if there's any problem in applying it in a built-out
tree, but the VPATH scenario seems like a problem in any case,
especially since (IIUC) meson builds have to be done that way.

I wouldn't object to adding more logic to the calling script
to support multiple usage scenarios, of course.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-05-25 13:20:32 Re: pgindent vs. pgperltidy command-line arguments
Previous Message PostgreSQL Global Development Group 2023-05-25 13:08:16 PostgreSQL 16 Beta 1 Released!