Re: Use bsearch() instead of a manual binary search in syscache.c

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> One factor is that libc bsearch() implementations might not all be
> header-only and inlineable. I vaguely recall that being discussed in
> some round of hacking on qsort() and qunique().

I'm quite certain that years ago we determined that bsearch()
was slower than a manually written-out loop, probably because of
exactly the point that the comparisons would be inline. Don't
know whether modern compilers have changed that conclusion.

There are places where we wouldn't care about such microscopic
performance details, but I think syscache.c is not one of them.

regards, tom lane