Re: pg_dump Add dumping of comments on index columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, higepon <higepon(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump Add dumping of comments on index columns
Date: 2009-07-23 23:02:45
Message-ID: 14646.1248390165@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Brendan Jurd <direvus(at)gmail(dot)com> writes:
> I've also done an initial review of the patch. Everything looks sane
> and the patch works as advertised. I made a couple of minor tweaks
> for code-style and comment consistency, and my version 3 is attached.

> I'm marking this patch Ready for Committer.

Applied with minor revisions --- mostly, it leaked memory in the case
of no comments, and the query wasn't very schema-safe.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-07-23 23:06:07 Re: join regression failure on cygwin
Previous Message Andrew Dunstan 2009-07-23 22:43:45 Re: join regression failure on cygwin