Re: problems with configure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Martin A(dot) Marques" <martin(at)math(dot)unl(dot)edu(dot)ar>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: problems with configure
Date: 2000-11-08 21:01:57
Message-ID: 14639.973717317@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Martin A. Marques" <martin(at)math(dot)unl(dot)edu(dot)ar> writes:
>>>> Is there any kind of info you would need that I could provide?
>>
>> If you could put
>> #include <sys/types.h>
>> #include <sys/socket.h>
>> into a file temp.c, and then send the output of "gcc -E temp.c",
>> it might shed some light.

> There it goes!!

Well, that tells the tale all right: the critical lines are

typedef uint32_t socklen_t;

typedef void *Psocklen_t;

extern int accept(int, struct sockaddr *, Psocklen_t);

What brainless idiot decided it would be a good idea to declare
accept's last argument as void*, do you suppose? (At least you
report that Solaris 8 no longer has this folly, so they did get
a clue eventually.)

Not sure what to do about this. It will clearly not do to define
ACCEPT_TYPE_ARG3 as void. Perhaps we need a special case for
Solaris 7: if we detect that accept() is declared with "void *",
assume that socklen_t is the thing to use. Peter, any thoughts?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martin A. Marques 2000-11-08 21:11:42 Re: problems with configure
Previous Message Peter Eisentraut 2000-11-08 19:55:37 Re: Location of client header files