Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> If you aren't willing to deal with a variable value for the block size,
>> please revert this patch.
> The problem is that I have hard-coded 8k into various text strings and I
> didn't want to make that variable. How should it behave if they are
> using a non-8k wal buffer size? Should it still use 8k or not? I
> figured throwing an error would at least alert them to the mismatch.
Well, as I said, if you aren't willing to put effort into that point,
just revert the patch. Making the program refuse to do anything doesn't
help *anyone*. Stats taken using a fixed 8K blocksize are better than
no stats at all.
regards, tom lane