| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Jingtang Zhang <mrdrivingduck(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH] vacuum: stop using stream ring after failsafe |
| Date: | 2026-08-06 22:04:17 |
| Message-ID: | 1460393.1786053857@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Melanie Plageman <melanieplageman(at)gmail(dot)com> writes:
> Okay, I pushed it, but right after pushing it I suddenly had the
> thought, omg, it loops through all the ReadBuffersOperations and sets
> them to NULL for _every_ page after entering failsafe mode. And we
> obviously ought to fix that. Proposed patch to do that with a simple
> local variable is attached. This time I'll let this one sit for longer
> before pushing to avoid mistakes like last time.
Don't wait too long, unless you want to revert 112c26838 et al
till after the upcoming releases. As things stand right now,
we'd ship what is in git.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandre Felipe | 2026-08-06 22:13:21 | Index skip-merge scan |
| Previous Message | Melanie Plageman | 2026-08-06 21:50:16 | Re: [PATCH] vacuum: stop using stream ring after failsafe |