Do we still need gen_node_support.pl's nodetag ABI stability check?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Do we still need gen_node_support.pl's nodetag ABI stability check?
Date: 2026-04-14 05:04:33
Message-ID: 1458883.1776143073@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

We're still a couple months away from cutting the REL_19_STABLE
branch, but I was contemplating that just now, and it occurred to me
to wonder whether we still need gen_node_support.pl's single-purpose
ABI check (cf commit eea9fa9b2) now that we have buildfarm animals
running general-purpose ABI stability checks.

On the one hand, there's much to be said for belt-and-suspenders-too
safety checks. On the other hand, updating gen_node_support.pl is
an extra manual step while creating a branch, so it's easy to forget
or get wrong. It's also not very clear why this particular sort
of ABI break in a stable branch is any worse than other hazards.

I'm not really set either way, but my first thought is to drop
the special mechanism.

regards, tom lane

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-04-14 05:19:08 Re: POC: Comparison of partitioning key values
Previous Message shveta malik 2026-04-14 04:57:08 Re: Improve logical replication usability when tables lack primary keys