Re: [COMMITTERS] pgsql: Clean up Perl code according to perlcritic

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Clean up Perl code according to perlcritic

This seems to have broken the regression tests (specifically, dblink)
on at least some of the Windows buildfarm critters. It looks like
something got changed in the behavior of build-tree path expansion:
this in the input/paths.source file

CREATE FUNCTION putenv(text)
RETURNS void
AS '@libdir@/regress(at)DLSUFFIX@', 'regress_putenv'
LANGUAGE C STRICT;

results in

CREATE FUNCTION putenv(text)
RETURNS void
RETURNS void
AS 'C:/buildfarm/HEAD/pgsql.build/contrib/dblink/$(top_builddir)/src/test/regress/regress.dll', 'regress_putenv'
LANGUAGE C STRICT;
+ ERROR: could not access file "C:/buildfarm/HEAD/pgsql.build/contrib/dblink/$(top_builddir)/src/test/regress/regress.dll": No such file or directory

which is surely not what it ought to be.

regards, tom lane