| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pgbench: Support double constants and functions. |
| Date: | 2016-03-29 04:56:19 |
| Message-ID: | 14517.1459227379@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Mar 29, 2016 at 9:52 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> pgbench: Support double constants and functions.
> Instead of INT64_MIN and INT64_MAX, I think that it would be better to
> use PG_INT64_MIN and PG_INT64_MAX.
Indeed.
> Note as well that DOUBLE is an
> existing variable type in VS (while INTEGER is not),
Ooops; that one was harder to foresee.
> A way to fix compilation here is to rename those tokens to something
> that will never conflict, like in the attached to DOUBLE_VAR and
> INTEGER_VAR, both exprparse.y and exprparse.l need an update.
Agreed, but these symbols represent constants not variables, so
I used DOUBLE_CONST and INTEGER_CONST instead. Pushed with those
corrections, so that we can get back to looking at my own bugs :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-03-29 05:00:50 | Re: [COMMITTERS] pgsql: pgbench: Support double constants and functions. |
| Previous Message | Tom Lane | 2016-03-29 04:53:59 | pgsql: Fix portability issues in 86c43f4e22c0771fd0cc6bce2799802c894ee2 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-03-29 05:00:50 | Re: [COMMITTERS] pgsql: pgbench: Support double constants and functions. |
| Previous Message | Amit Kapila | 2016-03-29 04:38:55 | Re: Relation extension scalability |