| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] packing/alignment annotation for ItemPointerData redux |
| Date: | 2016-10-19 16:51:35 |
| Message-ID: | 14482.1476895895@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
> Sorry -- with the obvious error fixed:
You didn't show -E output from this version, but the other one had
> __attribute__((packed))
> __attribute__((aligned(2)))
so it appears that clang 4.0 does accept these attributes but then
produces the warning anyway. I suggest filing this as a bug in clang 4.0,
and marking it as a regression from older versions which did not produce
such a warning.
If you get pushback claiming it's intentional, I'd be inclined to hack
our macro definitions so that we don't believe clang understands
attribute(aligned), because it evidently doesn't. But let's see
their response first.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-10-19 19:06:51 | Re: pgsql: Make getrusage() output a little more readable |
| Previous Message | Greg Stark | 2016-10-19 16:36:07 | Re: [COMMITTERS] packing/alignment annotation for ItemPointerData redux |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Claudio Freire | 2016-10-19 16:55:39 | Re: Indirect indexes |
| Previous Message | Andreas Joseph Krogh | 2016-10-19 16:49:34 | Re: Move pg_largeobject to a different tablespace *without* turning on system_table_mods. |