| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Roman Lozko <lozko(dot)roma(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: libpq fails to build with TSAN |
| Date: | 2024-01-31 22:28:25 |
| Message-ID: | 1442471F-76DB-4C81-8A62-BCBCB7C5181F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 31 Jan 2024, at 16:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> I think it should, the idea of that check is to catch calls to actual exits,
>> while this is instrumentation which has nothing to do with exit(2). The
>> attached diff should be enough to handle this.
>
> +1
Pushed. It can be argued that it should be backpatched, but for now I've only
pushed it to master. If there are strong opinions on backpatching I'd be happy
to fix that.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-01-31 22:48:05 | Re: Documentation: warn about two_phase when altering a subscription |
| Previous Message | Peter Smith | 2024-01-31 22:12:59 | Re: Improve the connection failure error messages |