Re: pgsql: Provide a TLS init hook

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Provide a TLS init hook
Date: 2020-03-26 15:31:13
Message-ID: 14349.1585236673@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 3/26/20 9:50 AM, Tom Lane wrote:
>> Why is jacana doing it differently?

> longfin is also running it (first) here
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=longfin&dt=2020-03-26%2014%3A39%3A51&stg=ssl_passphrase_callback-check

Oh, I missed that. Isn't that pretty duplicative of the
testmodules-install phase?

> I don't think this belongs in installcheck, we should add
> 'NO_INSTALLCHECK = 1' to the Makefile.

Why? The other src/test/modules/ modules with TAP tests do not
specify that, with the exception of commit_ts which has a solid
doesnt-work-in-the-default-configuration excuse.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2020-03-26 20:07:42 Re: pgsql: Provide a TLS init hook
Previous Message Andrew Dunstan 2020-03-26 15:15:32 Re: pgsql: Revert "initdb: Change authentication defaults"

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-03-26 15:37:48 Re: backup manifests
Previous Message Andrew Dunstan 2020-03-26 15:11:08 Re: pgsql: Provide a TLS init hook