Re: missing description initdb manual

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: shigeru(dot)hanada(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: missing description initdb manual
Date: 2012-04-14 14:32:57
Message-ID: 14193.1334413977@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tatsuo Ishii <ishii(at)postgresql(dot)org> writes:
> BTW, while editing the document, I noticed that pg_ctl.c's help
> message lacks some long options which are actually in the source code:
> '--timeout' and '--mode'. Included is the proposed patch to fix the
> problem. If there's no objection, I would like to commit it. Comments?

I think this line needs some more thought:

> - printf(_(" -m SHUTDOWN-MODE can be \"smart\", \"fast\", or \"immediate\"\n"));
> + printf(_(" -m, --mode SHUTDOWN-MODE can be \"smart\", \"fast\", or \"immediate\"\n"));

because it's not respecting the intended alignment of the explanation
column. (It wasn't before, either, but that's not an excuse to not fix
it.) I think you could make it read just "-m, --mode MODE" and then
there would be room to align this switch's explanation with the ones
above it. I'm tempted to also say that the explanation should be
MODE can be \"smart\", \"fast\", or \"immediate\"

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2012-04-14 14:39:26 Re: column name of pg_stat_replication.backend_start
Previous Message Fujii Masao 2012-04-14 14:28:39 Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.