| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [COMMITTERS] pgsql: Diagnose incompatible OpenLDAP versions during build and test. |
| Date: | 2014-07-24 00:45:44 |
| Message-ID: | 14174.1406162744@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Tue, Jul 22, 2014 at 11:51:18AM -0400, Tom Lane wrote:
>> Hmm. I'm pretty sure it is not considered good style to drop AC_DEFUN
>> blocks right into configure.in; at least, we have never done that before.
>> PGAC_LDAP_SAFE should get defined somewhere in config/*.m4, instead.
>> I am not real sure however which existing config/ file is appropriate,
>> or whether we should create a new one. Peter, any opinion?
> I don't mind reinstating the absence of AC_DEFUN from configure.in. Add
> config/misc-libraries.m4, perhaps? Alternately, stretch programs.m4; it
> already has two readline library checks.
programs.m4 sounds like the place then.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2014-07-24 02:21:17 | pgsql: Fix TAP installcheck tests when current directory name contains |
| Previous Message | Noah Misch | 2014-07-24 00:37:01 | Re: [COMMITTERS] pgsql: Diagnose incompatible OpenLDAP versions during build and test. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-07-24 01:44:10 | Re: Making joins involving ctid work for the benefit of UPSERT |
| Previous Message | Noah Misch | 2014-07-24 00:37:01 | Re: [COMMITTERS] pgsql: Diagnose incompatible OpenLDAP versions during build and test. |