| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: EXECUTE tab completion |
| Date: | 2011-10-20 19:53:35 |
| Message-ID: | 14119.1319140415@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> What I suggest is that we redefine previous_word() as returning an empty
> string, not NULL, anytime there is no such preceding word. This is
> better than the current behavior because (a) it's less surprising and
> (b) it's not ambiguous. Right now the caller can't tell the difference
> between "DROP" and "DROP DROP DROP".
> With that change, the correct test at line 795 would become
> else if (pg_strcasecmp(prev_wd, "DROP") == 0 &&
> prev2_wd[0] == '\0')
I've committed this --- please adjust the EXECUTE patch to match.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2011-10-20 20:17:33 | Re: Update on documentation builds on OSX w/ macports |
| Previous Message | Robert Haas | 2011-10-20 16:01:55 | Re: [v9.2] DROP statement reworks |