From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)postgreSQL(dot)org |
Cc: | Jan Wieck <jan(at)wi3ck(dot)info> |
Subject: | Re: I propose killing PL/Tcl's "modules" infrastructure |
Date: | 2017-02-26 18:09:31 |
Message-ID: | 14094.1488132571@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> Now, we could try to fix this bug, and add the regression test coverage
> that the code clearly lacks, and upgrade the documentation about it from
> its currently very sad state. But I think the right answer is just to
> remove the feature altogether.
BTW, I tried to poke into what it would take to write some regression test
coverage, and immediately hit a show-stopper:
$ pltcl_loadmod --help
can't find package Pgtcl
while executing
"package require Pgtcl"
(file "/home/postgres/testversion/bin/pltcl_loadmod" line 10)
That is, these scripts depend on the old Tcl client library, which
we removed from our core distro in 2004 (cf commit 41fa9e9ba).
So we don't even have a way of creating self-contained tests for them.
At this point I think there's no question that src/pl/tcl/modules/
needs to go away. There might be some argument for retaining the
"autoload the unknown module" startup behavior in pltcl proper, but
I think that Andrew Dunstan's proposal of calling an initialization
function is a far cleaner solution.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-02-26 18:12:21 | Re: [Bug fix] PQsendQuery occurs error when target_session_attrs is set to read-write |
Previous Message | Peter Geoghegan | 2017-02-26 18:04:20 | Re: Should logtape.c blocks be of type long? |