Re: pgsql/src/backend/postmaster (postmaster.c)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
Cc: pgsql-committers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: pgsql/src/backend/postmaster (postmaster.c)
Date: 2000-07-03 04:32:22
Message-ID: 14068.962598742@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

"Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> Seems you have changed the position of ResetAllOptions() as follows.

> + /*
> + * Options setup
> + */
> if (getenv("PGDATA"))
> DataDir = strdup(getenv("PGDATA")); /* default value */

> if (getenv("PGPORT"))
> PostPortName = atoi(getenv("PGPORT"));

> + ResetAllOptions();

Hmm, actually I was trying to move it to after the memory-context
creation code, but I guess your point is that ResetAllOptions() is
ignoring these env-var-based settings. Seems like the correct fix
is that guc.c ought to be handling this logic, not postmaster.c.
Peter, what do you think?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Hiroshi Inoue 2000-07-03 04:45:10 pgsql/src/backend/utils/time (tqual.c)
Previous Message Hiroshi Inoue 2000-07-03 04:26:59 RE: pgsql/src/backend/postmaster (postmaster.c)

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Broytmann 2000-07-03 07:43:47 Re: Built with PostgreSQL (images)
Previous Message Hiroshi Inoue 2000-07-03 04:26:59 RE: pgsql/src/backend/postmaster (postmaster.c)