From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
Cc: | Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: extension_control_path and "directory" |
Date: | 2025-05-02 14:51:55 |
Message-ID: | 1405b3ce-8e16-46de-aa9c-0bddac87e479@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 29.04.25 17:06, Matheus Alcantara wrote:
> On Tue, Apr 29, 2025 at 11:08 AM David E. Wheeler <david(at)justatheory(dot)com> wrote:
>> Right. My point is a minor one, but I thin you can use an if/ else there:
>>
>> ```c
>> if (strcmp(piece, "$system") == 0) {
>> /* Substitute the path macro if needed */
>> mangled = substitute_path_macro(piece, "$system", system_dir);
>> } else {
>> /*
>> * Append "extension" suffix in case is a custom extension
>> * control path.
>> */
>> mangled = psprintf("%s/extension", mangled);
>> }
>> ```
>>
>
> The substitute_path_macro() already handles the if/else on "piece" but I
> think that this if/else version looks nicer. Fixed.
>
> I've also included some documentation changes for this v5 version to
> remove the "extension" from the examples and also mention the scenario
> when using the "directory" on the .control file.
Thanks, I have committed this. I did a bit of code reformatting and
adjusted the documentation a bit. It's good to get this in before beta1
so that we don't have to change the valid values of
extension_control_path past beta1.
From | Date | Subject | |
---|---|---|---|
Next Message | Matheus Alcantara | 2025-05-02 15:04:06 | Re: extension_control_path and "directory" |
Previous Message | Peter Eisentraut | 2025-05-02 14:44:31 | pgsql: Make "directory" setting work with extension_control_path |
From | Date | Subject | |
---|---|---|---|
Next Message | Matheus Alcantara | 2025-05-02 15:04:06 | Re: extension_control_path and "directory" |
Previous Message | Andrey Borodin | 2025-05-02 13:00:29 | Small fixes needed by high-availability tools |