| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Steven Niu <niushiji(at)gmail(dot)com>, Pierre <pierre(dot)forstmann(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] check kernel version for io_method |
| Date: | 2026-01-14 07:27:07 |
| Message-ID: | 13f98612-9f3a-4604-8df9-a3406a10def8@proxel.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/14/26 8:22 AM, Steven Niu wrote:
> I agree that you are correct for now. But in future, the IoMethod may have new member. Then we have to process it.
>
> How about change to like this:
> + #else
> + if (*newval == IOMETHOD_IO_URING)
> + {
> + GUC_check_errdetail("io_uring not enabled.");
> + return false;
> + }
No, that would be incorrect. It would not even compile.
IOMETHOD_IO_URING is not even defined if we do not compile with liburing
enabled. You can try it out yourself by compiling PostgreSQL without
io_uring support and then try to enable it. You will get an error and
that code will never be reached.
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steven Niu | 2026-01-14 07:31:09 | Re: [PATCH] check kernel version for io_method |
| Previous Message | Steven Niu | 2026-01-14 07:22:35 | Re: [PATCH] check kernel version for io_method |