Re: Changing the state of data checksums in a running cluster

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2026-04-04 22:27:00
Message-ID: 13E0B47C-66DF-47A3-906E-7ED341D24A6A@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Apr 2026, at 02:35, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 4 Apr 2026, at 00:59, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 3 Apr 2026, at 23:46, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>>
>>> After many more runs on CI I ended up pushing this version, and I see BF
>>> members being angry due the test not waiting for the launcher to exit. I am
>>> working on a fix right now.
>>
>> 0036232ba8f seems to have made the failing animals slightly happier, I will
>> continue to monitor the buildfarm for other fallout.
>
> The intermittent failure on kestrel implies timing similar to the one fixed in
> 0036232ba8fb28, a tentative fix is to make it part of waiting for an endstate
> (on or off) to make sure the cluster is always in the right state for new
> operations. Right now kestrel is the one which has been flapping, I'm waiting
> a bit to see if more will follow and give further clues.

mylodon had the same failure, and I believe the bug is in my injection point
test code. I have a tentative fix in the attached refactoring which moves over
to using the injection_point extension module. It's still fairly rare so I'm
holding off for a little bit before pushing it to see if I can collect a little
bit more evidence.

--
Daniel Gustafsson

Attachment Content-Type Size
0002-Refactor-checksum-injection-point-tests.patch application/octet-stream 10.8 KB
0001-Wait-for-launcher-exit-in-enable-disable-checksum-te.patch application/octet-stream 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-04-04 22:35:50 Re: Add pg_stat_autovacuum_priority
Previous Message Andres Freund 2026-04-04 22:16:10 Re: PG 19 release notes and authors