| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4) |
| Date: | 2013-01-11 19:01:40 |
| Message-ID: | 13996.1357930900@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> The attached patch:
> * adds configure checks for __VA_ARGS__ and __builtin_unreachable
> support
> * provides a pg_unreachable() macro that expands to
> __builtin_unreachable() or abort()
> * changes #define elog ... into #define elog(elevel, ...) if varargs are
> available
Seems like a good thing to do --- will review and commit.
> It does *not* combine elog_start and elog_finish into one function if
> varargs are available although that brings a rather measurable
> size/performance benefit.
Since you've apparently already done the measurement: how much?
It would be a bit tedious to support two different infrastructures for
elog(), but if it's a big enough win maybe we should.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-01-11 19:33:29 | Re: Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4) |
| Previous Message | Simon Riggs | 2013-01-11 18:53:47 | Re: Performance Improvement by reducing WAL for Update Operation |