From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Speaking of breaking compatibility...standard_conforming_strings |
Date: | 2016-05-24 19:57:05 |
Message-ID: | 13982.1464119825@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> I just noticed this comment in scan.l:
> /*
> * GUC variables. This is a DIRECT violation of the warning given at the
> * head of gram.y, ie flex/bison code must not depend on any GUC variables;
> * as such, changing their values can induce very unintuitive behavior.
> * But we shall have to live with it as a short-term thing until the switch
> * to SQL-standard string syntax is complete.
> */
> int backslash_quote = BACKSLASH_QUOTE_SAFE_ENCODING;
> bool escape_string_warning = true;
> bool standard_conforming_strings = true;
> I'm not exactly sure what else needs to happen to remove these forbidden
> GUCs and if we are not prepared to do this now when will we ever be...
Dunno, are you prepared to bet that nobody is turning off
standard_conforming_strings anymore?
In any case, we keep adding new violations of this rule (cf
operator_precedence_warning) so I have little hope that it will ever be
completely clean.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2016-05-24 20:01:40 | Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
Previous Message | Kevin Grittner | 2016-05-24 19:48:35 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |