[patch] pg_test_timing does not prompt illegal option

From: "Zhang, Jie" <zhangjie2(at)cn(dot)fujitsu(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "Zhang, Jie" <zhangjie2(at)cn(dot)fujitsu(dot)com>
Subject: [patch] pg_test_timing does not prompt illegal option
Date: 2019-04-17 08:05:32
Message-ID: 1396E95157071C4EBBA51892C5368521017F2F2C72@G08CNEXMBPEKD02.g08.fujitsu.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

pg_test_timing accepts the following command-line options:
-d duration
--duration=duration

Specifies the test duration, in seconds. Longer durations give slightly better accuracy, and are more likely to discover problems with the system clock moving backwards. The default test duration is 3 seconds.
-V
--version

Print the pg_test_timing version and exit.
-?
--help

Show help about pg_test_timing command line arguments, and exit.

[https://www.postgresql.org/docs/11/pgtesttiming.html]

However, when I use the following command, no error prompt. the command can run.
pg_test_timing --

I think "--" is a illegal option, errors should be prompted.

Here is a patch for prompt illegal option.

Best Regards!

Attachment Content-Type Size
pg_test_timing.patch application/octet-stream 933 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-04-17 09:58:46 Re: hyrax vs. RelationBuildPartitionDesc
Previous Message Paul Guo 2019-04-17 07:56:30 standby recovery fails (tablespace related) (tentative patch and discussion)