| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Erik Wienhold <ewie(at)ewie(dot)name> |
| Cc: | Michal Bartak <maxym(dot)srpl(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: CASE control block broken by a single line comment |
| Date: | 2024-04-13 05:45:35 |
| Message-ID: | 13903.1712987135@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Erik Wienhold <ewie(at)ewie(dot)name> writes:
> On 2024-04-13 00:20 +0200, Tom Lane wrote:
>> I'm not here to defend plpgsql's factorization ;-). However, it
>> doesn't really have a parser of its own, at least not for expressions,
>> so I'm not sure how your suggestion could be made to work.
> Not a suggestion. Just a question about the general design, unrelated
> to this fix, in case you know the answer off the cuff. I see that
> 863a62064c already had the lexer handle those compound tokens, but
> unfortunately without an explanation on why. Never mind if that's too
> much to ask about a design descision made over 25 years ago.
Well, it was a design decision I wasn't involved in, so I dunno.
You could reach out to Jan on the slim chance he remembers.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-04-13 06:58:07 | Re: UUID v7 |
| Previous Message | John Naylor | 2024-04-13 05:40:55 | Re: cpluspluscheck/headerscheck require build in REL_16_STABLE |