| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Garick Hamlin <ghamlin(at)isc(dot)upenn(dot)edu> |
| Cc: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial |
| Date: | 2010-01-05 19:42:03 |
| Message-ID: | 13902.1262720523@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Garick Hamlin <ghamlin(at)isc(dot)upenn(dot)edu> writes:
> On Tue, Jan 05, 2010 at 02:02:51PM -0500, Tom Lane wrote:
>> I'm not nearly good enough in Perl to be sure about the semantics
>> of this loop. Is it possible that it's changing the global contents
>> of the @$data structure, rather than just hacking a local copy of
>> each row before pushing some values into @fmgr?
> Yes, that is what would happen.
> Is that a problem? (I haven't read the script)
Well, it *shouldn't* be a problem, but what it looks like to me is
that Stefan's perl version is somehow leaking one copy of the whole
$data structure each time through the loop. If we were to copy and
then modify each row individually, maybe that'd dodge the bug.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2010-01-05 19:43:56 | Re: Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial |
| Previous Message | Garick Hamlin | 2010-01-05 19:37:51 | Re: Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2010-01-05 19:43:56 | Re: Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial |
| Previous Message | Scott Bailey | 2010-01-05 19:39:38 | Re: Proposal: XML helper functions |