| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: What to do with inline warnings? |
| Date: | 2008-05-14 19:48:36 |
| Message-ID: | 1390.1210794516@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> Fwiw, these two call sites are only for when HeapTupleSatisfiesMVCC finds a
> tuples which has been moved away by VACUUM FULL... The latter for when it
> finds such a tuple but the VACUUM FULL aborted.
> It seems quite likely that the compiler is actually right (by chance) and we
> shouldn't be optimizing those cases at the expense of more common cases.
I trimmed the original message quite a bit --- there were a lot more
than two call sites that it was deciding not to inline. Maybe it's
making the right choices or maybe not.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-05-14 19:51:45 | Re: bug in localized \df+ output |
| Previous Message | daveg | 2008-05-14 19:47:27 | Re: libpq object hooks |