Re: newlines at end of generated SQL

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: fabriziomello(at)gmail(dot)com
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: newlines at end of generated SQL
Date: 2014-01-11 03:21:47
Message-ID: 1389410507.12505.5.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2014-01-09 at 15:52 -0200, Fabrízio de Royes Mello wrote:
>
> On Thu, Jan 9, 2014 at 3:34 PM, Robert Haas <robertmhaas(at)gmail(dot)com>
> wrote:
> >
> > On Wed, Jan 8, 2014 at 10:17 PM, Peter Eisentraut <peter_e(at)gmx(dot)net>
> wrote:
> > > Is there a reason why the programs in src/bin/scripts all put
> newlines
> > > at the end of the SQL commands they generate? This produces
> useless
> > > empty lines in the server log (and client output, if selected).
> >
> > If you're asking whether you can go ahead and fix that, +1 from me.
> >
>
> Well... I did that...

But you also need to add the newlines back for the --echo output.
(Might as well use puts() then.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2014-01-11 03:40:19 Re: [PATCH] Add transforms feature
Previous Message Florian Pflug 2014-01-11 03:19:30 Re: [PATCH] Negative Transition Aggregate Functions (WIP)