Re: [bug fix] pg_ctl fails with config-only directory

"MauMau" <maumau307(at)gmail(dot)com> writes:
> From: "Heikki Linnakangas" <hlinnakangas(at)vmware(dot)com>
>> Hmm, why do this only on Windows? If "postgres -C" is safe enough to run
>> as Administrator on Windows, why not allow running it as root on Unix as
>> well? Even if there's no particular need to allow it as root on Unix,
>> fewer #ifdefs is good.

> Yes, I limited the change only to Windows, because I thought I might get get
> objection against unnecessary change. Plus, --single should not be allowed
> for root, because root cannot be the PostgreSQL user account.

Indeed, and why would that not apply to Windows as well? AFAIK, inclusion
of --single in this list is just plain nuts. The most likely result of
running that way is creation of root-owned files inside $PGDATA, which
would cause havoc for later normally-privileged postmasters.

I will go and commit this, without the #ifdefs and without the --single
exclusion.

regards, tom lane