| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Smith <gsmith(at)gregsmith(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [GENERAL] pgbench not setting scale size correctly? |
| Date: | 2008-05-09 14:48:35 |
| Message-ID: | 13891.1210344515@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-patches |
Greg Smith <gsmith(at)gregsmith(dot)com> writes:
> Turns out it wasn't so contorted. Updated patch attached that only warns
> in the exact cases where the setting is ignored, and the warning says how
> it's actually setting the scale.
It looks like the code could do with some refactoring. AFAICS
scale is stored into all the :scale variables at lines 1671-1691
(although not if you only have one client !?) only to be done over
again at lines 1746-1763 (though not if ttype != 3). Wasteful,
confusing, and there's a case where it fails to be done at all.
Sigh ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-09 15:55:04 | Re: [GENERAL] pgbench not setting scale size correctly? |
| Previous Message | mailtolouis2020-postgres | 2008-05-09 14:36:13 | Duplicated primary key id happen |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-05-09 14:52:16 | Re: Verified fix for Bug 4137 |
| Previous Message | Tom Lane | 2008-05-09 14:39:33 | Re: [HACKERS] [NOVICE] encoding problems |